Repository navigation
feat(autoware): use nalgebra for common types - #775
romancardenas wants to merge 4 commits into
Conversation
|
@nokosaaan I pushed a new commit addressing your review. I think that, eventually, this port can benefit from adapting data types to the Rust ecosystem, so probably using nalgebra's native data types could be beneficial. That is why I marked the new Let me know what you think! |
d91bbd4 to
a883769
Compare
|
@romancardenas I agree with the direction: Regarding
For this PR, I'd only ask for two small things, if you don't mind:
Other follow-ups I'll handle separately: the gyro_odometer frame_id / covariance fix, replacing ekf_localizer's own Thanks again for the quick iteration! |
|
@nokosaaan I addressed your requested changes! |
|
@romancardenas |
Description
Instead of defining custom types for
Vector3,Quaternion, etc., this PR usesnalgebranative types.The main benefits is that we can use a lot of methods and functionalities provided by this package.
IMPORTANT: packages do not depend directly on
nalgebra. Instead,common_typesserves as a common framework where we re-export the functionalities we consider necessary.I adapted the current autoware packages to follow this approach. The most important changes can be found in
imu_corrector.I think this change will allow us to better scale as we include functionalities to autoware. I am about to start addressing #748 and detected that this restructuring would be beneficial.
How was this PR tested?
scripts/ci.shpasses on my machine.